Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mrr k #1961

Merged
merged 11 commits into from
Aug 3, 2023
Merged

Feature/mrr k #1961

merged 11 commits into from
Aug 3, 2023

Conversation

lucadiliello
Copy link
Contributor

@lucadiliello lucadiliello commented Aug 1, 2023 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #1935

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

📚 Documentation preview 📚: https://torchmetrics--1961.org.readthedocs.build/en/1961/

@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Merging #1961 (9dc8008) into master (7cda67c) will decrease coverage by 46%.
Report is 1 commits behind head on master.
The diff coverage is 85%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #1961     +/-   ##
========================================
- Coverage      83%     37%    -46%     
========================================
  Files         265     265             
  Lines       15134   15145     +11     
========================================
- Hits        12588    5601   -6987     
- Misses       2546    9544   +6998

@SkafteNicki SkafteNicki added the enhancement New feature or request label Aug 1, 2023
@SkafteNicki SkafteNicki added this to the v1.1.0 milestone Aug 1, 2023
SkafteNicki
SkafteNicki approved these changes Aug 1, 2023
View reviewed changes
src/torchmetrics/retrieval/average_precision.py Outdated Show resolved Hide resolved
src/torchmetrics/retrieval/reciprocal_rank.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Aug 1, 2023
@Borda Borda enabled auto-merge (squash) August 1, 2023 18:26
Borda
Borda approved these changes Aug 1, 2023
View reviewed changes
src/torchmetrics/retrieval/reciprocal_rank.py Outdated Show resolved Hide resolved
@Borda Borda merged commit ea17ffb into Lightning-AI:master Aug 3, 2023
@lucadiliello lucadiliello deleted the feature/mrr_k branch August 4, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@Borda Borda Borda approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@stancld stancld Awaiting requested review from stancld stancld is a code owner

Assignees

@lucadiliello lucadiliello

Labels
enhancement New feature or request ready
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Add MRR@K as an option to MRR
3 participants
@lucadiliello @Borda @SkafteNicki